[PATCH] D77780: Remove -implicit-check-not=foo from X86/disassemble-functions.test

Thu Apr 9 02:40:57 PDT 2020

xiangzhangllvm added a comment.

In D77780#1971343 <https://reviews.llvm.org/D77780#1971343>, @Higuoxing wrote:

> I guess we want to test dumping different symbols here. If we specify `--disassemble-symbols=main`, we don't want `llvm-objdump` to dump the content of `foo` here. So, we should ensure `llvm-objdump` will not print `foo`. At least, I think we should not remove `--implicit-check-not="<foo>:"`, but improve the robustness of checking?

--disassemble-symbols=main should just show main's function.  From the finding target address in llvm-objdump code seem do not care about  "--disassemble-symbols".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77780/new/

https://reviews.llvm.org/D77780