[PATCH] D77607: [FileCheck] Fix --dump-input annotation sort per input line

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 01:36:10 PDT 2020


thopre added a comment.

In D77607#1970773 <https://reviews.llvm.org/D77607#1970773>, @jdenny wrote:

> In D77607#1970655 <https://reviews.llvm.org/D77607#1970655>, @thopre wrote:
>
> > LGTM. Thanks for this, I haven't used feature so far but that seems very useful with this patch.
>
>
> Cool.  Thanks for the review.
>
> (By the way, some time ago I started developing patches to show variable captures as annotations on input lines.  I've found that really helpful when debugging.  They need more work, such as adding support for numeric variables.  I'll try to get those into phabricator soon.)


So you mean it show the value when it's captured as opposed to when it's used like what -vv shows? Or is there more to it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77607/new/

https://reviews.llvm.org/D77607





More information about the llvm-commits mailing list