[PATCH] D77706: [Darwin] Fix symbolization for recent simulator runtimes.

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp:109
+  // `new_env_entry` should be `=`.
+  uptr CopyEnv(char **current_env, const char *new_env_entry) {
+    uptr new_entry_index = 0;
----------------
I would like this to be done with a sequence of call for helper functions: 1) Copy, 2) AddOrReplace. Please separate the symbolizer-specific logic (printing the warning, using `custom_env_` as the destination) from the env manipulation logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77706/new/

https://reviews.llvm.org/D77706