[PATCH] D77276: Clean up usages of asserting vector getters in Type

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 16:52:17 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/IR/Function.cpp:1067
+    return VectorType::get(Ty->getElementType(),
+                           {(unsigned)Ty->getNumElements(), true});
   }
----------------
ctetreau wrote:
> efriedma wrote:
> > Does VectorType::getNumElements() not return unsigned?
> it's uint64_t. getVectorNumElements() was unsigned, it just did the conversion
I added D77763 to change it. Most of the calls to this were through getVectorNumElements() anyways, which did the cast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77276/new/

https://reviews.llvm.org/D77276





More information about the llvm-commits mailing list