[PATCH] D77515: [mlir] Remove need for static global ctors from mlir-translate

Jonathan Roelofs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 16:19:08 PDT 2020


jroelofs added a comment.
Herald added a subscriber: frgossen.

In D77515#1965197 <https://reviews.llvm.org/D77515#1965197>, @jroelofs wrote:

> I tried this out with `BUILD_SHARED_LIBS=ON`, and unfortunately ran into a problem with the way this custom rtti behaves


snip

> Should fixing that be a blocker to landing this patch?

Per discussion on Discord, I'll land this patch without solving that, since it's an incremental improvement and doesn't regress the behavior here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77515/new/

https://reviews.llvm.org/D77515





More information about the llvm-commits mailing list