[PATCH] D73306: llvm-addr2line: assume addresses on the command line are hexadecimal rather than attempting to guess the base based on the form of the number.

Wed Apr 8 14:41:08 PDT 2020

rsmith added a comment.

In D73306#1968815 <https://reviews.llvm.org/D73306#1968815>, @jhenderson wrote:

> So I think the design for Phabricator is intended to be one review per commit. I vaguely recall someone saying this was also the preferred style for reviews in LLVM in general, in one of the Github PRs versus Phabricator threads. Certainly, I find it easiest to work in that way. I don't know if arcanist has any way of linking things like this (I don't use it), but if you put "Depends on DXXXX" in your patch description, it will create a commit "Stack" tab which shows the commit thread (see D77308 <https://reviews.llvm.org/D77308> for an example of the Stack tab). You can also do it manually using the "Edit Related Revisions" UI option.

I found an article describing the workflow I want <https://medium.com/@kurtisnusbaum/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6>, and some folks at Mozilla are working on automating it <https://moz-conduit.readthedocs.io/en/latest/arcanist-user.html#series-of-commits>. But yeah, it seems like doing the phabricator review management yourself manually is the only way at the moment :-( Ah well, and thanks for the information. In any case, I think this is the patch you wanted to review, with the other bits already committed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73306/new/

https://reviews.llvm.org/D73306