[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 12:30:25 PDT 2020


smeenai added inline comments.


================
Comment at: llvm/CMakeLists.txt:7
+  message(WARNING
+    "The current CMake version is ${CMAKE_VERSION}. As soon as the release "
+    "branch for LLVM 11.0.0 is created, the minimum version of CMake required "
----------------
How about "Your CMake version" or "The CMake version you're using" or something like that, instead of "The current CMake version"? To me, "The current CMake version" is ambiguous – it could mean *your* current CMake version, or it could mean the minimum CMake version currently required by LLVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77740/new/

https://reviews.llvm.org/D77740





More information about the llvm-commits mailing list