[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 12:30:24 PDT 2020


smeenai added a comment.

In D77740#1969886 <https://reviews.llvm.org/D77740#1969886>, @jyknight wrote:

> I don't think there's any point in delaying until after the 11 release. We just branched LLVM 10. I believe we should make the change between now and the September LLVM 11 release, rather than afterwards.
>
> I'd propose instead:
>
> 1. Add a warning like this -- but saying the minimum will be upgraded SOON, not in 11.0.0.
> 2. Keep the warning for a month -- meanwhile work on getting all buildbots upgraded
> 3. Promote the warning to an error, make sure buildbots are still working. Potentially revert and re-apply later, if there are issues.
> 4. Start cleaning up cruft for compat with old versions, yay!


I believe the 3.13.4 minimum is predicated on the Ubuntu 20.04 LTS release, which will have CMake 3.16.3 available, at which point Debian 10 (which has CMake 3.13.4) will be our limiting OS. (The current Ubuntu LTS, 18.04, has CMake 3.10.2.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77740/new/

https://reviews.llvm.org/D77740





More information about the llvm-commits mailing list