[PATCH] D77635: [LV] Vectorize with FoldTail when Primary Induction is absent

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 11:24:13 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1148
+class VPWidenPrimaryInductionRecipe : public VPRecipeBase {
+private:
+  VPValue *Val = nullptr;
----------------
nit: private not needed here, right? Classes should default to private


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1149
+private:
+  VPValue *Val = nullptr;
+
----------------
Could be a unique_ptr?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77635/new/

https://reviews.llvm.org/D77635





More information about the llvm-commits mailing list