[PATCH] D77740: [CMake] Add a warning message to prepare the upcoming upgrade to CMake 3.13.4

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 10:19:02 PDT 2020


jyknight added a comment.

I don't think there's any point in delaying until after the 11 release. We just branched LLVM 10. I believe we should make the change between now and the September LLVM 11 release, rather than afterwards.

I'd propose instead:

1. Add a warning like this -- but saying the minimum will be upgraded SOON, not in 11.0.0.
2. Keep the warning for a month -- meanwhile work on getting all buildbots upgraded
3. Promote the warning to an error, make sure buildbots are still working. Potentially revert and re-apply later, if there are issues.
4. Start cleaning up cruft for compat with old versions, yay!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77740/new/

https://reviews.llvm.org/D77740





More information about the llvm-commits mailing list