[PATCH] D77733: [libunwind] Enable the new libc++ testing format by default

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 08:07:47 PDT 2020


ldionne created this revision.
Herald added subscribers: libcxx-commits, llvm-commits, dexonsmith, jkorous.
Herald added projects: LLVM, libunwind.
Herald added a reviewer: libunwind.

The new format should be equivalent to the old format, and it is now the
default format when running the libc++ and libc++abi tests. This commit
changes the libunwind tests to use the new format by default too. If
unexpected failures are discovered, it should be fine to revert this
commit until they are addressed.

Also note that it is still possible to use the old format by passing
`--param=use_old_format=True` when running Lit for the time being.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77733

Files:
  libunwind/test/lit.cfg


Index: libunwind/test/lit.cfg
===================================================================
--- libunwind/test/lit.cfg
+++ libunwind/test/lit.cfg
@@ -67,9 +67,10 @@
 configuration = config_module.Configuration(lit_config, config)
 configuration.configure()
 configuration.print_config_info()
-if lit_config.params.get('use_new_format', False):
-    lit_config.note("Using the experimental libc++ testing format")
+if lit_config.params.get('use_old_format', False):
+    lit_config.note("Using the old libc++ testing format")
+    config.test_format = configuration.get_test_format()
+else:
+    lit_config.note("Using the new libc++ testing format")
     import libcxx.test.newformat
     config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()
-else:
-    config.test_format = configuration.get_test_format()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77733.256024.patch
Type: text/x-patch
Size: 828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200408/9781b9eb/attachment.bin>


More information about the llvm-commits mailing list