[PATCH] D77528: [MLIR] Add support to use aligned_alloc to lower AllocOp from std to llvm

Wed Apr 8 05:23:25 PDT 2020

bondhugula added a comment.

In D77528#1969104 <https://reviews.llvm.org/D77528#1969104>, @ftynse wrote:

> In D77528#1969077 <https://reviews.llvm.org/D77528#1969077>, @bondhugula wrote:
>
> > I don't have GCC-5 at hand to be sure of the fix. Any insights?
>
>
> Neither do I... I would expect `using AllocaOpLowering = AllocLikeOpLowering<AllocaOp>;` instead of creating a derived class could get rid of the problem with constructors, and this is the right thing to have anyway.

Thanks - I just went ahead and committed this: D77719 <https://reviews.llvm.org/D77719>. Where can I get the buildkite URL for a commit?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77528/new/

https://reviews.llvm.org/D77528