[PATCH] D77590: [ARM] MVE saturating truncates

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Cheers, nice optimisation. 
One nit/question that doesn't need another review.



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14759
+
+  if (VT != MVT::v4i32 && VT != MVT::v8i16)
+    return SDValue();
----------------
ah yes, `&&`, boolean logic, it always confuses me ;-)


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14796
+
+    // Create a VQMOVNB, Signed extended in to the top half. That extend will
+    // hopefully be removed if only the bottom bits are demanded (though a
----------------
sorry, just double checking again, should this be: 

  Signed extended in to the bottom half. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77590/new/

https://reviews.llvm.org/D77590