[PATCH] D77528: [MLIR] Add support to use aligned_alloc to lower AllocOp from std to llvm

Wed Apr 8 02:08:15 PDT 2020

ftynse accepted this revision.
ftynse added a comment.
This revision is now accepted and ready to land.

> Everything's addressed now but you may want to take another look because I had completely missed the fact earlier that aligned_alloc only supports a size that is a multiple of alignment.

I was going to ask what happened in case of `memref<?xvector<3xf32>>` but got distracted by the lambda discussion :)

================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:1595
+  /// The minimum alignment to use with aligned_alloc (has to be a power of 2).
+  uint64_t kMinAignedAllocAlignment = 16UL;
 };
----------------
Typo: Aigned 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77528/new/

https://reviews.llvm.org/D77528