[PATCH] D77700: [VE] Simplify definitions of uimm6 and simm7

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 00:30:05 PDT 2020


kaz7 marked an inline comment as done.
kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:29
+def uimm6 : Operand<i32>, PatLeaf<(imm), [{
+    return isUInt<6>(N->getZExtValue()); }]>;
+
----------------
simoll wrote:
> How come there is a `DecoderMethod` for `simm7` but not for `uimm6`? I am not saying this is wrong but i'd like to understand why this works.
We don't need decoder functions for unsigned values since the default decoder method works correctly for unsigned immediate values.  In order to sign-extend values, we need particular functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77700/new/

https://reviews.llvm.org/D77700





More information about the llvm-commits mailing list