[PATCH] D77693: [AMDGPU] Expand vector trunc stores from i16 to i8

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 18:00:21 PDT 2020


rampitec added a comment.

In D77693#1968350 <https://reviews.llvm.org/D77693#1968350>, @rampitec wrote:

> In D77693#1968323 <https://reviews.llvm.org/D77693#1968323>, @arsenm wrote:
>
> > Can merge with the existing store tests
>
>
> Which file do you prefer?


In fact that was long annoying me, we have many tests with zillions of functions. When I need to debug I first have to find which function has failed, then extract it.

I understand that we do not want to have a billion of files, but really a number of failures does not tell much anymore and a four or even five digit line number within a test usually discourages.

I know it is not only me, after all that is why we have all that update* scripts. Then we update a huge test and I refuse to believe everybody really looks to all the changes. We are saving on forks, but we are loosing in test quality I suppose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77693/new/

https://reviews.llvm.org/D77693





More information about the llvm-commits mailing list