[PATCH] D77253: [MLIR][Vector] Update ShapeCastOp folder to use producer-consumer value forwarding.

Andy Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 13:03:58 PDT 2020


andydavis1 marked 2 inline comments as done.
andydavis1 added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:787
+      functional::zipApply(apply,
+                           SmallVector<int64_t, 4>{sourceVectorShape.rbegin(),
+                                                   sourceVectorShape.rend()},
----------------
rriddle wrote:
> I would expect llvm::reverse() to work here.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77253/new/

https://reviews.llvm.org/D77253





More information about the llvm-commits mailing list