[PATCH] D77253: [MLIR][Vector] Update ShapeCastOp folder to use producer-consumer value forwarding.

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/lib/Dialect/Vector/VectorTransforms.cpp:765
+      if (shapeCastOp.source().getType().isa<TupleType>())
+        break;
+      assert(tupleIndex == -1);
----------------
a break is effectively a return nullptr, right? so, given how far the while/return are, why not use that to make it more clear? same appplies to other breaks (also given you have a few return nullptr here and there too)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77253/new/

https://reviews.llvm.org/D77253