[PATCH] D74706: [WIP][DebugInfo][LiveDebugValues] Index variable location IDs by machine location

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

> I was looking at a benchmark for glyph rendering in WebKit. Unfortunately, the file appears to reference headers from an Apple-internal SDK, and I can't find an analogous benchmark in open source. I've stashed the bitcode for now: happy to benchmark future patches against it if requested.

Righty-ho, I think I've got a reasonable body of benchmarks otherwise,

> Re: the early-exits [0, 1] you linked to, I don't understand why these exist. It could be a compile-time hack, but I'm not sure about that, because the loop over OpenLocs remains O(n). Do you expect getting rid of the early exits to result in a large increase in VarLocs? I suppose I'd expect a small/modest increase.

It's odd; the return turned up in [2] in transferSpillInst and was duplicated in [3], possibly it's just an oversight. My fear is that large numbers of inlined variables could be transferred but currently aren't. This is a hunch though, at some point I'll have numbers to analyse.

[2] https://reviews.llvm.org/D29500
[3] https://reviews.llvm.org/D44016


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74706/new/

https://reviews.llvm.org/D74706