[PATCH] D77635: [LV] Vectorize with FoldTail when Primary Induction is absent

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 03:12:52 PDT 2020


fhahn added a comment.

Thanks for the patch, Ayal!

I've put up D77577 <https://reviews.llvm.org/D77577> yesterday to allow mapping the primary IV used to a different IR value during codegen as alternative, but I think adding the recipe is more straight forward in the end, as there is a single place we need to use the primary IV.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:333
+  /// Hold the primary induction phi of the vector loop.
+  Value *PrimaryInduction = nullptr;
+
----------------
Maybe include Vector in the name, e.g. VectorInduction, to avoid confusion with Legal's PrimaryInduction


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1166
+
+  /// Generate the wide load/store.
+  void execute(VPTransformState &State) override;
----------------
Comment needs updating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77635/new/

https://reviews.llvm.org/D77635





More information about the llvm-commits mailing list