[PATCH] D77579: [llvm-objcopy] Support bfdname "elf32-hexagon"

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-output-target.test:33-34
 
+# RUN: llvm-objcopy -I binary -O elf32-hexagon %t.txt %t.hexagon.o
+# RUN: llvm-readobj --file-headers %t.hexagon.o | FileCheck %s --check-prefixes=CHECK,LE,HEXAGON,32
+
----------------
FWIW, I'd probably have put this RUN line in the same order as the checks below. If you're okay doing some reordering, that would be great, but I think there is more than one case that needs it.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/cross-arch-headers.test:109-110
+# RUN: llvm-objcopy %t.o -O elf32-hexagon %t.elf32_hexagon.o --split-dwo=%t.elf32_hexagon.dwo
+# RUN: llvm-readobj --file-headers %t.elf32_hexagon.o | FileCheck %s --check-prefixes=CHECK,LE,HEXAGON,32,SYSV
+# RUN: llvm-readobj --file-headers %t.elf32_hexagon.dwo | FileCheck %s --check-prefixes=CHECK,LE,HEXAGON,32,SYSV
+
----------------
Same comment as in the other test. Matching the cases with the check order would make a lot of sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77579/new/

https://reviews.llvm.org/D77579