[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM

I had a VC meeting wtih maskray to discuss concerns he has, and he is ok with this patch. I'm fine with this patch too. I'll give a final LGTM to unblock you. Please make the following changes and submit. Thanks!



================
Comment at: lld/ELF/LTO.cpp:84
+  if (!config->ltoBasicBlockSections.empty()) {
+    if (config->ltoBasicBlockSections == "all")
+      c.Options.BBSections = BasicBlockSection::All;
----------------
nit: if else has {}, add {} to other `if` and `else if` clauses.


================
Comment at: lld/ELF/LTO.cpp:94-95
+      if (!MBOrErr) {
+        errs() << "Error loading basic block sections function list file: "
+               << MBOrErr.getError().message() << "\n";
+      } else {
----------------
Please use `error()` to report an error and use the same style as other error messages. E.g.

  error("cannot open " + config->ltoBasicBlockSections + ":" + MBOrErr.getError().message());



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065