[PATCH] D77357: [PowerPC][UpdateTestChecks] Remove the extra # when scrubbing loop comments

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang marked 2 inline comments as done.
ZhangKang added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/asm.py:236
+  # Stripe unimportant loop comments.
+  asm = common.SCRUB_LOOP_COMMENT_RE.sub(r'', asm)
   # Strip trailing whitespace.
----------------
jsji wrote:
> Why we want to scrub loop comment **TWICE**?
> If the extra comments `#` is bothering you, 
> can we try to add one regex to scrub it **AFTER** SCRUB_LOOP_COMMENT_RE?
> 
> Something like:
> ```
> asm = common.SCRUB_LOOP_COMMENT_RE.sub(r'#', asm)
> asm = common.SCRUB_TAILING_COMMENT_TOKEN_RE.sub(r'', asm)
> ```
> 
Yes, removing the tailing token '#' is a better method. I will add one regex to remove the token '#'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77357/new/

https://reviews.llvm.org/D77357