[PATCH] D77535: [GlobalISel] Add extended inline assembler support

Mon Apr 6 18:01:37 PDT 2020

aemerson added a comment.

In D77535#1964668 <https://reviews.llvm.org/D77535#1964668>, @kschwarz wrote:

> > Is this just to feel out the general approach?
>
> Yes, this is mostly to see how the logic would look like in GlobalISel land.
>
> > Maybe it would make sense to take a similar approach to CallLowering here and split inline ASM lowering into its own thing, which targets can build upon?
>
> I posted this patch together with an RFC on llvm-dev (http://lists.llvm.org/pipermail/llvm-dev/2020-April/140661.html) where I would like to discuss exactly that approach.
>
> Thanks to you both for having a look already!

I've just replied to the RFC, but to re-iterate, I think having a generic lowering class for this code makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77535/new/

https://reviews.llvm.org/D77535