[PATCH] D77580: [llvm-objdump] Fix incomplete relocation output for -D -r mode

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 17:29:28 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1579
         if (Obj->getArch() != Triple::hexagon) {
           // Print relocation for instruction.
           while (RelCur != RelEnd) {
----------------
I think this comment is out of date. There might be others in this block.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1589
             // Stop when RelCur's offset is past the current instruction.
             if (Offset >= Index + Size)
               break;
----------------
I think XCOFF32 is working because the pointer length is the same as the instruction length?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77580/new/

https://reviews.llvm.org/D77580





More information about the llvm-commits mailing list