[PATCH] D77426: [SampleFDO] Add flag for non-dedicated profile.

Mon Apr 6 16:22:14 PDT 2020

wenlei accepted this revision.
wenlei added a comment.

In D77426#1964396 <https://reviews.llvm.org/D77426#1964396>, @wmi wrote:

> In D77426#1961284 <https://reviews.llvm.org/D77426#1961284>, @wenlei wrote:
>
> > Thanks for the patch! We're also thinking about differentiating default profile (from other targets) vs custom profile (from same target) for optimizations, so very curious about your compiler heuristic changes after this. :) I am guessing `ProfileSampleAccurate` and `ProfileAccurateForSymsInList` will one of those changes?
>
>
> `ProfileSampleAccurate` and `ProfileAccurateForSymsInList` are already off by default so it is not urgent to guard the logic with the partial profile flag unless `ProfileSampleAccurate` and `ProfileAccurateForSymsInList` will be enabled by default.
>
> An example for compiler heuristic to change is ProfileSummaryInfo::hasLargeWorkingSetSize/hasHugeWorkingSetSize. If the profile is a partial profile,  those functions should return false in any case because there is no way to know the actual working set size from a partial profile.

Thanks for clarification, looking forward to the coming heuristic improvements.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77426/new/

https://reviews.llvm.org/D77426