[PATCH] D76742: [lld] Add basic symbol table output

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 14:43:23 PDT 2020


MaskRay added a comment.

In D76742#1965176 <https://reviews.llvm.org/D76742#1965176>, @Ktwu wrote:

> @ruiu
>
> Since D76839 <https://reviews.llvm.org/D76839> is based on this diff, it'd be easier to land this diff as-is so that D76839 <https://reviews.llvm.org/D76839> doesn't have to rebase. Any qualms about landing as-is and then changing the write order in another diff?


For a patch series, amending an earlier patch may require the rebase of subsequent patches. I think that is just how things work. Email based reviews (e.g. `[PATCH 0/5]`) work this way, too. I don't think a question can be dismissed just because "landing a patch as-is can avoid rebasing future patches".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76742/new/

https://reviews.llvm.org/D76742





More information about the llvm-commits mailing list