[PATCH] D77276: Clean up usages of asserting vector getters in Type

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 14:10:43 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/IR/Constants.cpp:231
+  auto *VTy = dyn_cast<VectorType>(getType());
+  if (!VTy || VTy->isScalable())
     return false;
----------------
Please don't add new isScalable checks in this patch.  (Here, and other places in this file.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77276/new/

https://reviews.llvm.org/D77276





More information about the llvm-commits mailing list