[PATCH] D77273: Clean up usages of asserting vector getters in Type

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 13:37:48 PDT 2020


ctetreau marked an inline comment as done.
ctetreau added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:156
 
+  auto *CVTy = cast<VectorType>(C->getType());
+
----------------
efriedma wrote:
> Given there are three "cast<>"s and three uses, the variable probably isn't worth it.
Yeah. Darn imperative languages!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77273/new/

https://reviews.llvm.org/D77273





More information about the llvm-commits mailing list