[PATCH] D77557: [DWARFDebugLine] Use truncating data extractors for prologue parsing
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 12:30:53 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:457
- uint64_t ExpectedEnd =
- Prologue.TotalLength - 2 + Prologue.sizeofTotalLength();
+ uint64_t ExpectedEnd = Prologue.TotalLength + Prologue.sizeofTotalLength() -
+ (Version != 5 ? 2 : 8);
----------------
At a first glance, 2 : 8 looks a bit magical. This may deserve a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77557/new/
https://reviews.llvm.org/D77557
More information about the llvm-commits
mailing list