[PATCH] D77576: [globalisel] Add lost debug locations verifier

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp:369
+                                      /*MBB=*/&*MF.begin());
+    R << "lost " << std::to_string(LocObserver.getNumLostDebugLocs())
+      << " debug locations during pass";
----------------
paquette wrote:
> Can this use NV?
> 
> E.g. something like
> 
> ```
> R << "lost " << NV("NumLostDebugLocs", LocObserver.getNumLostDebugLocs()) << " debug locations during pass";
> ```
> 
> I think that would make optimization records easier to parse, if you choose to save them.
> 
> It would also be nice to have a testcase for the remarks.
Although that being said, any testcase that exposes this is a bug we should fix, so... maybe it's not reasonable to test it. :)

It would be nice to know what the opt remark output looks like though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77576/new/

https://reviews.llvm.org/D77576