[PATCH] D77530: [AArch64][GlobalISel] Generalize logic for subregister copies

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 10:18:52 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:764-765
+      copySubReg(I, MRI, RBI, Copy.getReg(0), DstRC, SubReg);
+    } else if (SrcSize > DstSize) {
+      const TargetRegisterClass *SubregRC = getMinClassForRegBank(
+          SrcRegBank, DstSize, /* GetAllRegSet */ true);
----------------
It's weird that we have this case and also the case above which checks `getMinSizeForRegBank(SrcRegBank) > DstSize`. Is this a typo?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77530/new/

https://reviews.llvm.org/D77530





More information about the llvm-commits mailing list