[compiler-rt] d0498fa - Revert "[sanitizer_common] Show new unexpected symbols."

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 09:58:17 PDT 2020


Author: Matt Morehouse
Date: 2020-04-06T09:58:03-07:00
New Revision: d0498faeae084961547689db6c81d4e59985e32f

URL: https://github.com/llvm/llvm-project/commit/d0498faeae084961547689db6c81d4e59985e32f
DIFF: https://github.com/llvm/llvm-project/commit/d0498faeae084961547689db6c81d4e59985e32f.diff

LOG: Revert "[sanitizer_common] Show new unexpected symbols."

This reverts commit 68d73dfa1a422fd045e25d06c3e8ff01621c377a.

Added: 
    

Modified: 
    compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
index a5262520305f..be79f1df64ba 100755
--- a/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
+++ b/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
@@ -178,10 +178,8 @@ $CC $FLAGS -fno-lto -c opt.bc -o symbolizer.o
 
 echo "Checking undefined symbols..."
 nm -f posix -g symbolizer.o | cut -f 1,2 -d \  | LC_COLLATE=C sort -u > undefined.new
-if 
diff  -u $SCRIPT_DIR/global_symbols.txt undefined.new | grep -E "^\+[^+]"; then
-  echo "Failed: unexpected symbols"
-  exit 1
-fi
+(
diff  -u $SCRIPT_DIR/global_symbols.txt undefined.new | grep -E "^\+[^+]") && \
+  (echo "Failed: unexpected symbols"; exit 1)
 
 arch() {
   objdump -f $1 | grep -m1 -Po "(?<=file format ).*$"


        


More information about the llvm-commits mailing list