[llvm] 9822024 - [NFC][PPC][AIX] Test updates for byval args that fit in a single register
Chris Bowler via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 07:31:58 PDT 2020
Author: Chris Bowler
Date: 2020-04-06T10:31:11-04:00
New Revision: 982202408bb0bcacb3a401d251d948f3ba8827b2
URL: https://github.com/llvm/llvm-project/commit/982202408bb0bcacb3a401d251d948f3ba8827b2
DIFF: https://github.com/llvm/llvm-project/commit/982202408bb0bcacb3a401d251d948f3ba8827b2.diff
LOG: [NFC][PPC][AIX] Test updates for byval args that fit in a single register
Differential Revision: https://reviews.llvm.org/D76875
Added:
Modified:
llvm/test/CodeGen/PowerPC/aix-cc-byval.ll
Removed:
################################################################################
diff --git a/llvm/test/CodeGen/PowerPC/aix-cc-byval.ll b/llvm/test/CodeGen/PowerPC/aix-cc-byval.ll
index c886e357967a..fd86a60ce490 100644
--- a/llvm/test/CodeGen/PowerPC/aix-cc-byval.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-cc-byval.ll
@@ -105,84 +105,111 @@ entry:
; ASM64-NEXT: lbz 3, 48(1)
; ASM64-NEXT: blr
+
+ at f = common global float 0.000000e+00, align 4
+
%struct.S2 = type { [2 x i8] }
@gS2 = external global %struct.S2, align 1
define void @call_test_byval_2Byte() {
entry:
- %call = call zeroext i8 @test_byval_2Byte(%struct.S2* byval(%struct.S2) align 1 @gS2)
+ %0 = load float, float* @f, align 4
+ %call = call zeroext i8 @test_byval_2Byte(i32 signext 42, float %0, %struct.S2* byval(%struct.S2) align 1 @gS2, float %0, i32 signext 43)
ret void
}
; CHECK-LABEL: name: call_test_byval_2Byte{{.*}}
-; 32BIT: ADJCALLSTACKDOWN 56, 0, implicit-def dead $r1, implicit $r1
-; 32BIT-NEXT: renamable $r[[REG:[0-9]+]] = LWZtoc @gS2, $r2 :: (load 4 from got)
-; 32BIT-NEXT: renamable $r3 = LHZ 0, killed renamable $r[[REG]] :: (load 2)
-; 32BIT-NEXT: renamable $r3 = RLWINM killed renamable $r3, 16, 0, 15
-; 32BIT-NEXT: BL_NOP <mcsymbol .test_byval_2Byte>, csr_aix32, implicit-def dead $lr, implicit $rm, implicit $r3, implicit $r2, implicit-def $r1
+; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
+; 32BIT: renamable $r[[REG1:[0-9]+]] = LWZtoc @f, $r2 :: (load 4 from got)
+; 32BIT-NEXT: renamable $f1 = LFS 0, killed renamable $r[[REG1]] :: (dereferenceable load 4 from @f)
+; 32BIT-NEXT: ADJCALLSTACKDOWN 56, 0, implicit-def dead $r1, implicit $r1
+; 32BIT-DAG: $r3 = LI 42
+; 32BIT-DAG: renamable $r[[REG2:[0-9]+]] = LWZtoc @gS2, $r2 :: (load 4 from got)
+; 32BIT-DAG: renamable $r[[REG3:[0-9]+]] = LHZ 0, killed renamable $r[[REG2]] :: (load 2)
+; 32BIT-DAG: renamable $r5 = RLWINM killed renamable $r[[REG3]], 16, 0, 15
+; 32BIT-DAG: $f2 = COPY renamable $f1
+; 32BIT-DAG: $r7 = LI 43
+; 32BIT-NEXT: BL_NOP <mcsymbol .test_byval_2Byte>, csr_aix32, implicit-def dead $lr, implicit $rm, implicit $r3, implicit $f1, implicit $r5, implicit killed $f2, implicit killed $r7, implicit $r2, implicit-def $r1
; 32BIT-NEXT: ADJCALLSTACKUP 56, 0, implicit-def dead $r1, implicit $r1
; CHECKASM-LABEL: .call_test_byval_2Byte:
+; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
; ASM32: stwu 1, -64(1)
-; ASM32-NEXT: lwz [[REG:[0-9]+]], LC{{[0-9]+}}(2)
-; ASM32-NEXT: lhz 3, 0([[REG]])
-; ASM32-NEXT: slwi 3, 3, 16
+; ASM32-DAG: li 3, 42
+; ASM32-DAG: lwz [[REG1:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM32-DAG: lfs 1, 0([[REG1]])
+; ASM32-DAG: lwz [[REG2:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM32-DAG: lhz [[REG3:[0-9]+]], 0([[REG2]])
+; ASM32-DAG: slwi 5, [[REG3]], 16
+; ASM32-DAG: fmr 2, 1
+; ASM32-DAG: li 7, 43
; ASM32-NEXT: bl .test_byval_2Byte
; ASM32-NEXT: nop
; ASM32-NEXT: addi 1, 1, 64
-; 64BIT: ADJCALLSTACKDOWN 112, 0, implicit-def dead $r1, implicit $r1
-; 64BIT-NEXT: renamable $x[[REG:[0-9]+]] = LDtoc @gS2, $x2 :: (load 8 from got)
-; 64BIT-NEXT: renamable $x3 = LHZ8 0, killed renamable $x[[REG]] :: (load 2)
-; 64BIT-NEXT: renamable $x3 = RLDICR killed renamable $x3, 48, 15
-; 64BIT-NEXT: BL8_NOP <mcsymbol .test_byval_2Byte>, csr_aix64, implicit-def dead $lr8, implicit $rm, implicit $x3, implicit $x2, implicit-def $r1
+; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
+; 64BIT: renamable $x[[REG1:[0-9]+]] = LDtoc @f, $x2 :: (load 8 from got)
+; 64BIT-NEXT: renamable $f1 = LFS 0, killed renamable $x[[REG1]] :: (dereferenceable load 4 from @f)
+; 64BIT-NEXT: ADJCALLSTACKDOWN 112, 0, implicit-def dead $r1, implicit $r1
+; 64BIT-DAG: $x3 = LI8 42
+; 64BIT-DAG: renamable $x[[REG2:[0-9]+]] = LDtoc @gS2, $x2 :: (load 8 from got)
+; 64BIT-DAG: renamable $x[[REG3:[0-9]+]] = LHZ8 0, killed renamable $x[[REG2]] :: (load 2)
+; 64BIT-DAG: renamable $x5 = RLDICR killed renamable $x[[REG3]], 48, 15
+; 64BIT-DAG: $f2 = COPY renamable $f1
+; 64BIT-DAG: $x7 = LI8 43
+; 64BIT-NEXT: BL8_NOP <mcsymbol .test_byval_2Byte>, csr_aix64, implicit-def dead $lr8, implicit $rm, implicit $x3, implicit $f1, implicit $x5, implicit killed $f2, implicit killed $x7, implicit $x2, implicit-def $r1
; 64BIT-NEXT: ADJCALLSTACKUP 112, 0, implicit-def dead $r1, implicit $r1
+; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
; ASM64: std 0, 16(1)
; ASM64-NEXT: stdu 1, -112(1)
-; ASM64-NEXT: ld [[REG:[0-9]+]], LC{{[0-9]+}}(2)
-; ASM64-NEXT: lhz 3, 0([[REG]])
-; ASM64-NEXT: sldi 3, 3, 48
+; ASM64-DAG: li 3, 42
+; ASM64-DAG: ld [[REG1:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM64-DAG: lfs 1, 0([[REG1]])
+; ASM64-DAG: ld [[REG2:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM64-DAG: lhz [[REG3:[0-9]+]], 0([[REG2]])
+; ASM64-DAG: sldi 5, [[REG3]], 48
+; ASM64-DAG: fmr 2, 1
+; ASM64-DAG: li 7, 43
; ASM64-NEXT: bl .test_byval_2Byte
; ASM64-NEXT: nop
; ASM64-NEXT: addi 1, 1, 112
-
-define zeroext i8 @test_byval_2Byte(%struct.S2* byval(%struct.S2) align 1 %s) {
+define zeroext i8 @test_byval_2Byte(i32, float, %struct.S2* byval(%struct.S2) align 1 %s, float, i32) {
entry:
%arrayidx = getelementptr inbounds %struct.S2, %struct.S2* %s, i32 0, i32 0, i32 1
- %0 = load i8, i8* %arrayidx, align 1
- ret i8 %0
+ %4 = load i8, i8* %arrayidx, align 1
+ ret i8 %4
}
; CHECK-LABEL: name: test_byval_2Byte
; 32BIT: fixedStack:
-; 32BIT-NEXT: - { id: 0, type: default, offset: 24, size: 4, alignment: 8, stack-id: default,
+; 32BIT-NEXT: - { id: 0, type: default, offset: 32, size: 4, alignment: 16, stack-id: default,
; 32BIT: bb.0.entry:
-; 32BIT-NEXT: liveins: $r3
-; 32BIT: STW killed renamable $r3, 0, %fixed-stack.0 :: (store 4 into %fixed-stack.0, align 8)
+; 32BIT-NEXT: liveins: $r5
+; 32BIT: STW killed renamable $r5, 0, %fixed-stack.0 :: (store 4 into %fixed-stack.0, align 16)
; 32BIT-NEXT: renamable $r3 = LBZ 1, %fixed-stack.0 :: (dereferenceable load 1
; 64BIT: fixedStack:
-; 64BIT-NEXT: - { id: 0, type: default, offset: 48, size: 8, alignment: 16, stack-id: default,
+; 64BIT-NEXT: - { id: 0, type: default, offset: 64, size: 8, alignment: 16, stack-id: default,
; 64BIT: bb.0.entry:
-; 64BIT-NEXT: liveins: $x3
-; 64BIT: STD killed renamable $x3, 0, %fixed-stack.0 :: (store 8 into %fixed-stack.0, align 16)
+; 64BIT-NEXT: liveins: $x5
+; 64BIT: STD killed renamable $x5, 0, %fixed-stack.0 :: (store 8 into %fixed-stack.0, align 16)
; 64BIT-NEXT: renamable $x3 = LBZ8 1, %fixed-stack.0 :: (dereferenceable load 1
; CHECKASM-LABEL: .test_byval_2Byte:
-; ASM32: stw 3, 24(1)
-; ASM32-NEXT: lbz 3, 25(1)
+; ASM32: stw 5, 32(1)
+; ASM32-NEXT: lbz 3, 33(1)
; ASM32-NEXT: blr
-; ASM64: std 3, 48(1)
-; ASM64-NEXT: lbz 3, 49(1)
+; ASM64: std 5, 64(1)
+; ASM64-NEXT: lbz 3, 65(1)
; ASM64-NEXT: blr
@@ -191,89 +218,126 @@ entry:
define void @call_test_byval_3Byte() {
entry:
- %call = call zeroext i16 @test_byval_3Byte(%struct.S3* byval(%struct.S3) align 1 @gS3)
+ %call = call zeroext i16 @test_byval_3Byte(i32 1, i32 2, i32 3, i32 4, i32 5, i32 6, i32 7, %struct.S3* byval(%struct.S3) align 1 @gS3, i32 42)
ret void
}
; CHECK-LABEL: name: call_test_byval_3Byte{{.*}}
; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
-; 32BIT: ADJCALLSTACKDOWN 56, 0, implicit-def dead $r1, implicit $r1
-; 32BIT-NEXT: renamable $r[[REGADDR:[0-9]+]] = LWZtoc @gS3, $r2 :: (load 4 from got)
+; 32BIT: ADJCALLSTACKDOWN 60, 0, implicit-def dead $r1, implicit $r1
+; 32BIT-DAG: $r3 = LI 1
+; 32BIT-DAG: $r4 = LI 2
+; 32BIT-DAG: $r5 = LI 3
+; 32BIT-DAG: $r6 = LI 4
+; 32BIT-DAG: $r7 = LI 5
+; 32BIT-DAG: $r8 = LI 6
+; 32BIT-DAG: $r9 = LI 7
+; 32BIT-DAG: renamable $r[[REGADDR:[0-9]+]] = LWZtoc @gS3, $r2 :: (load 4 from got)
; 32BIT-DAG: renamable $r[[REG1:[0-9]+]] = LHZ 0, killed renamable $r[[REGADDR]] :: (load 2)
; 32BIT-DAG: renamable $r[[REG2:[0-9]+]] = LBZ 2, renamable $r[[REGADDR]] :: (load 1)
-; 32BIT-DAG: renamable $r3 = RLWINM killed renamable $r[[REG2]], 8, 16, 23
-; 32BIT-DAG: renamable $r3 = RLWIMI killed renamable $r3, killed renamable $r[[REG1]], 16, 0, 15
-; 32BIT-NEXT: BL_NOP <mcsymbol .test_byval_3Byte>, csr_aix32, implicit-def dead $lr, implicit $rm, implicit $r3, implicit $r2, implicit-def $r1
-; 32BIT-NEXT: ADJCALLSTACKUP 56, 0, implicit-def dead $r1, implicit $r1
+; 32BIT-DAG: renamable $r10 = RLWINM killed renamable $r[[REG2]], 8, 16, 23
+; 32BIT-DAG: renamable $r10 = RLWIMI killed renamable $r10, killed renamable $r[[REG1]], 16, 0, 15
+; 32BIT-DAG: renamable $r[[REG3:[0-9]+]] = LI 42
+; 32BIT-DAG: STW killed renamable $r[[REG3]], 56, $r1 :: (store 4)
+; 32BIT-NEXT: BL_NOP <mcsymbol .test_byval_3Byte>, csr_aix32, implicit-def dead $lr, implicit $rm, implicit $r3, implicit $r4, implicit killed $r5, implicit killed $r6, implicit killed $r7, implicit killed $r8, implicit killed $r9, implicit $r10, implicit $r2, implicit-def $r1
+; 32BIT-NEXT: ADJCALLSTACKUP 60, 0, implicit-def dead $r1, implicit $r1
; CHECKASM-LABEL: .call_test_byval_3Byte:
; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
; ASM32: stwu 1, -64(1)
-; ASM32-NEXT: lwz [[REGADDR:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM32-DAG: li 3, 1
+; ASM32-DAG: li 4, 2
+; ASM32-DAG: li 5, 3
+; ASM32-DAG: li 6, 4
+; ASM32-DAG: li 7, 5
+; ASM32-DAG: li 8, 6
+; ASM32-DAG: li 9, 7
+; ASM32-DAG: lwz [[REGADDR:[0-9]+]], LC{{[0-9]+}}(2)
; ASM32-DAG: lhz [[REG1:[0-9]+]], 0([[REGADDR]])
; ASM32-DAG: lbz [[REG2:[0-9]+]], 2([[REGADDR]])
-; ASM32-DAG: rlwinm 3, [[REG2]], 8, 16, 23
-; ASM32-DAG: rlwimi 3, [[REG1]], 16, 0, 15
+; ASM32-DAG: rlwinm 10, [[REG2]], 8, 16, 23
+; ASM32-DAG: rlwimi 10, [[REG1]], 16, 0, 15
+; ASM32-DAG: li [[REG3:[0-9]+]], 42
+; ASM32-DAG: stw [[REG3]], 56(1)
; ASM32-NEXT: bl .test_byval_3Byte
; ASM32-NEXT: nop
; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
-; 64BIT: ADJCALLSTACKDOWN 112, 0, implicit-def dead $r1, implicit $r1
+; 64BIT: ADJCALLSTACKDOWN 120, 0, implicit-def dead $r1, implicit $r1
+; 64BIT-DAG: $x3 = LI8 1
+; 64BIT-DAG: $x4 = LI8 2
+; 64BIT-DAG: $x5 = LI8 3
+; 64BIT-DAG: $x6 = LI8 4
+; 64BIT-DAG: $x7 = LI8 5
+; 64BIT-DAG: $x8 = LI8 6
+; 64BIT-DAG: $x9 = LI8 7
; 64BIT-DAG: renamable $x[[REGADDR:[0-9]+]] = LDtoc @gS3, $x2 :: (load 8 from got)
; 64BIT-DAG: renamable $x[[REG1:[0-9]+]] = LHZ8 0, killed renamable $x[[REGADDR]] :: (load 2)
; 64BIT-DAG: renamable $x[[REG2:[0-9]+]] = LBZ8 2, renamable $x[[REGADDR]] :: (load 1)
-; 64BIT-DAG: renamable $x3 = RLDIC killed renamable $x[[REG2]], 40, 16
-; 64BIT-DAG: renamable $x3 = RLDIMI killed renamable $x3, killed renamable $x[[REG1]], 48, 0
-; 64BIT-NEXT: BL8_NOP <mcsymbol .test_byval_3Byte>, csr_aix64, implicit-def dead $lr8, implicit $rm, implicit $x3, implicit $x2, implicit-def $r1
-; 64BIT-NEXT: ADJCALLSTACKUP 112, 0, implicit-def dead $r1, implicit $r1
+; 64BIT-DAG: renamable $x10 = RLDIC killed renamable $x[[REG2]], 40, 16
+; 64BIT-DAG: renamable $x10 = RLDIMI killed renamable $x10, killed renamable $x[[REG1]], 48, 0
+; 64BIT-DAG: $x[[REG3:[0-9]+]] = LI8 42
+; 64BIT-DAG: STD killed renamable $x[[REG3]], 112, $x1 :: (store 8)
+; 64BIT-NEXT: BL8_NOP <mcsymbol .test_byval_3Byte>, csr_aix64, implicit-def dead $lr8, implicit $rm, implicit $x3, implicit $x4, implicit killed $x5, implicit killed $x6, implicit killed $x7, implicit killed $x8, implicit killed $x9, implicit $x10, implicit $x2, implicit-def $r1
+; 64BIT-NEXT: ADJCALLSTACKUP 120, 0, implicit-def dead $r1, implicit $r1
; The DAG block permits some invalid inputs for the benefit of allowing more valid orderings.
-; ASM64: stdu 1, -112(1)
-; ASM64-NEXT: ld [[REGADDR:[0-9]+]], LC{{[0-9]+}}(2)
+; ASM64: stdu 1, -128(1)
+; ASM64-DAG: li 3, 1
+; ASM64-DAG: li 4, 2
+; ASM64-DAG: li 5, 3
+; ASM64-DAG: li 6, 4
+; ASM64-DAG: li 7, 5
+; ASM64-DAG: li 8, 6
+; ASM64-DAG: li 9, 7
+; ASM64-DAG: ld [[REGADDR:[0-9]+]], LC{{[0-9]+}}(2)
; ASM64-DAG: lhz [[REG1:[0-9]+]], 0([[REGADDR]])
; ASM64-DAG: lbz [[REG2:[0-9]+]], 2([[REGADDR]])
-; ASM64-DAG: rldic 3, [[REG2]], 40, 16
-; ASM64-DAG: rldimi 3, [[REG1]], 48, 0
+; ASM64-DAG: rldic 10, [[REG2]], 40, 16
+; ASM64-DAG: rldimi 10, [[REG1]], 48, 0
+; ASM64-DAG: li [[REG3:[0-9]+]], 42
+; ASM64-DAG: std [[REG3]], 112(1)
; ASM64-NEXT: bl .test_byval_3Byte
; ASM64-NEXT: nop
-define zeroext i16 @test_byval_3Byte(%struct.S3* byval(%struct.S3) align 1 %s) {
+define zeroext i16 @test_byval_3Byte(i32, i32, i32, i32, i32, i32, i32, %struct.S3* byval(%struct.S3) align 1 %s, i32) {
entry:
%gep = getelementptr inbounds %struct.S3, %struct.S3* %s, i32 0, i32 1
- %0 = load i16, i16* %gep, align 1
- ret i16 %0
+ %8 = load i16, i16* %gep, align 1
+ ret i16 %8
}
; CHECK-LABEL: name: test_byval_3Byte
-; 32BIT: fixedStack:
-; 32BIT-NEXT: - { id: 0, type: default, offset: 24, size: 4, alignment: 8, stack-id: default,
-
-; 32BIT: bb.0.entry:
-; 32BIT-NEXT: liveins: $r3
-; 32BIT: STW killed renamable $r3, 0, %fixed-stack.0 :: (store 4 into %fixed-stack.0, align 8)
-; 32BIT-NEXT: renamable $r3 = LHZ 1, %fixed-stack.0 :: (dereferenceable load 2
+; 32BIT: fixedStack:
+; 32BIT-NEXT: - { id: 0, type: default, offset: 56, size: 4, alignment: 8, stack-id: default,
+; 32BIT: - { id: 1, type: default, offset: 52, size: 4, alignment: 4, stack-id: default,
-; 64BIT: fixedStack:
-; 64BIT-NEXT: - { id: 0, type: default, offset: 48, size: 8, alignment: 16, stack-id: default,
+; 32BIT-LABEL: bb.0.entry:
+; 32BIT-NEXT: liveins: $r10
+; 32BIT: STW killed renamable $r10, 0, %fixed-stack.1 :: (store 4 into %fixed-stack.1)
+; 32BIT-NEXT: renamable $r3 = LHZ 1, %fixed-stack.1 :: (dereferenceable load 2
-; 64BIT: bb.0.entry:
-; 64BIT-NEXT: liveins: $x3
-; 64BIT: STD killed renamable $x3, 0, %fixed-stack.0 :: (store 8 into %fixed-stack.0, align 16)
-; 64BIT-NEXT: renamable $x3 = LHZ8 1, %fixed-stack.0 :: (dereferenceable load 2
+; 64BIT: fixedStack:
+; 64BIT-NEXT: - { id: 0, type: default, offset: 116, size: 4, alignment: 4, stack-id: default,
+; 64BIT: - { id: 1, type: default, offset: 104, size: 8, alignment: 8, stack-id: default,
+; 64BIT-LABEL: bb.0.entry:
+; 64BIT-NEXT: liveins: $x10
+; 64BIT: STD killed renamable $x10, 0, %fixed-stack.1 :: (store 8 into %fixed-stack.1)
+; 64BIT-NEXT: renamable $x3 = LHZ8 1, %fixed-stack.1 :: (dereferenceable load 2
; CHECKASM-LABEL: .test_byval_3Byte:
-; ASM32: stw 3, 24(1)
-; ASM32-NEXT: lhz 3, 25(1)
+; ASM32: stw 10, 52(1)
+; ASM32-NEXT: lhz 3, 53(1)
; ASM32-NEXT: blr
-; ASM64: std 3, 48(1)
-; ASM64-NEXT: lhz 3, 49(1)
+; ASM64: std 10, 104(1)
+; ASM64-NEXT: lhz 3, 105(1)
; ASM64-NEXT: blr
More information about the llvm-commits
mailing list