[llvm] fef2dab - Bugix for buildbot failure at commit 43f031d31264d20cfb8f1ebd606c66e57c231d4d

Mon Apr 6 07:13:50 PDT 2020

Yeah, that would be a way to fix it I suppose.

But maybe reverting still makes sense until Philip's concern in the
original commit (43f031d) thread is addressed.

On Mon, Apr 6, 2020 at 3:22 PM Kai Luo <gluokai at gmail.com> wrote:
>
> How about adding `; REQUIRES: x86_64` at the top of the file?
>
> On Mon, Apr 6, 2020 at 9:10 PM Hans Wennborg via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > I see my fix didn't work. It failed on this buildbot:
> > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46780
> >
> > /home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/lli:
> > error: error creating EE: No available targets are compatible with
> > triple "x86_64-unknown-unknown"
> >
> > And it failed on 32-bit Windows as below. I've reverted the change
> > that introduced the test in 64c23127508 until it can be fixed
> > properly.
> >
> > FAIL: LLVM :: ExecutionEngine/MCJIT/cet-code-model-lager.ll (22607 of 36859)
> > ******************** TEST 'LLVM ::
> > ExecutionEngine/MCJIT/cet-code-model-lager.ll' FAILED
> > ********************
> > Script:
> > --
> > : 'RUN: at line 1';
> > c:\src\llvm_package_6a800f6f\build32_stage0\bin\lli.exe
> > -mtriple=i686-pc-windows-msvc-elf -mtriple=x86_64-unknown-unknown
> > -code-model=large
> > C:\src\llvm_package_6a800f6f\llvm-project\llvm\test\ExecutionEngine\MCJIT\cet-code-model-lager.ll
> > > /dev/null
> > --
> > Exit Code: 1
> >
> > Command Output (stdout):
> > --
> > $ ":" "RUN: at line 1"
> > $ "c:\src\llvm_package_6a800f6f\build32_stage0\bin\lli.exe"
> > "-mtriple=i686-pc-windows-msvc-elf" "-mtriple=x86_64-unknown-unknown"
> > "-code-model=large"
> > "C:\src\llvm_package_6a800f6f\llvm-project\llvm\test\ExecutionEngine\MCJIT\cet-code-model-lager.ll"
> > # command stderr:
> > lli.exe: for the --mtriple option: may only occur zero or one times!
> >
> > On Mon, Apr 6, 2020 at 2:24 PM Hans Wennborg <hans at chromium.org> wrote:
> > >
> > > What was the bug?
> > >
> > > Because now the test fails like this in my 32-bit Windows build:
> > >
> > > $ "c:\src\llvm_package_944db8a4\build32_stage0\bin\lli.exe"
> > > "-mtriple=i686-pc-windows-msvc-elf" "-code-model=large"
> > > "C:\src\llvm_package_944db8a4\llvm-project\llvm\test\ExecutionEngine\MCJIT\cet-code-model-lager.ll"
> > > # command stderr:
> > > Assertion failed: Is64Bit && "Large code model is only legal in 64-bit
> > > mode.", file C:\src\llvm_package_944db8a4\llvm-project\llvm\lib\Target\X86\X86ISelLowering.cpp,
> > > line 4212
> > >
> > > I committed a patch that passes the triple to lli in
> > > 6a800f6f622a7ade275fa6cb1ef07803460d8bb3, let's see how that goes.
> > >
> > > Also, I noticed this file (and another from your original commit) end
> > > with -lager.ll. Should it be -larger.ll? or -large.ll?
> > >
> > > Thanks,
> > > Hans
> > >
> > > On Fri, Apr 3, 2020 at 7:26 AM Xiang1 Zhang via llvm-commits
> > > <llvm-commits at lists.llvm.org> wrote:
> > > >
> > > >
> > > > Author: Xiang1 Zhang
> > > > Date: 2020-04-03T13:25:35+08:00
> > > > New Revision: fef2dab100dfc7c49ccf0ce2bacea409324b54ba
> > > >
> > > > URL: https://github.com/llvm/llvm-project/commit/fef2dab100dfc7c49ccf0ce2bacea409324b54ba
> > > > DIFF: https://github.com/llvm/llvm-project/commit/fef2dab100dfc7c49ccf0ce2bacea409324b54ba.diff
> > > >
> > > > LOG: Bugix for buildbot failure at commit 43f031d31264d20cfb8f1ebd606c66e57c231d4d
> > > > Author: Xiang1 Zhang <xiang1.zhang at intel.com>
> > > > Date:   Fri Apr 3 11:25:38 2020 +0800
> > > >
> > > >     Enable IBT(Indirect Branch Tracking) in JIT with CET(Control-flow Enforcement Technology)
> > > >
> > > > Added:
> > > >
> > > >
> > > > Modified:
> > > >     llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll
> > > >
> > > > Removed:
> > > >
> > > >
> > > >
> > > > ################################################################################
> > > > diff  --git a/llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll b/llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll
> > > > index 782a2b84a844..478683b016d3 100644
> > > > --- a/llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll
> > > > +++ b/llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll
> > > > @@ -1,5 +1,4 @@
> > > >  ; RUN: %lli -code-model=large %s > /dev/null
> > > > -target triple = "x86_64-unknown-linux-gnu"
> > > >
> > > >  @a = dso_local local_unnamed_addr global i32 1, align 4
> > > >
> > > >
> > > >
> > > >
> > > > _______________________________________________
> > > > llvm-commits mailing list
> > > > llvm-commits at lists.llvm.org
> > > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits