[PATCH] D77544: [AMDGPU] Moving SI_RETURN_TO_EPILOG handling out of SIInsertSkips.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 07:00:07 PDT 2020


arsenm added a comment.

I would expect there to be a test change? Did we not have a MIR test of this before?



================
Comment at: llvm/lib/Target/AMDGPU/SIPreEmitPeephole.cpp:166
+    case AMDGPU::SI_RETURN_TO_EPILOG:
+      // FIXME: Should move somewhere else
+      assert(!MF.getInfo<SIMachineFunctionInfo>()->returnsVoid());
----------------
Should elaborate that this is not an optimization


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77544/new/

https://reviews.llvm.org/D77544





More information about the llvm-commits mailing list