[PATCH] D77445: [ELF] -M/-Map: fix VMA/LMA/Size columns of symbol assignments when address/size>=2**32

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

The code change LG, few comments about the test.



================
Comment at: lld/test/ELF/map-file-kernel.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64 /dev/null -o %t.o
----------------
`map-file-kernel.s` probably doesn't describe the intention of the test? Not sure why there is "kernel" mentioned.


================
Comment at: lld/test/ELF/map-file-kernel.s:7
+# CHECK-NEXT:               0                0 ffffffff80000000     1 . = 0xffffffff80000000
+# CHECK-NEXT:ffffffff80000000                0   100000     1 . += 0x100000
+# CHECK-NEXT:ffffffff80100000                0        0     1 _text = .
----------------
The second check line looks broken/shifted because of the huge size it seems, isn't?
Are we going to fix it or was your intention just to document this behavior?
(If we want to fix this, I guess it can be done in another patch, but I'd probably add a comment regarding this line then).


================
Comment at: lld/test/ELF/map-file-kernel.s:11
+
+SECTIONS {
+  . = 0xffffffff80000000;
----------------
Perhaps would be good to add the comment daying what we wanted to test here.
Without knowledge about the code change it is unclear what is tested perhaps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77445/new/

https://reviews.llvm.org/D77445