[PATCH] D76602: [MLIR] Introduce std.alloca op

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 01:03:41 PDT 2020


bondhugula added a comment.

In D76602#1954032 <https://reviews.llvm.org/D76602#1954032>, @bondhugula wrote:

> In D76602#1951483 <https://reviews.llvm.org/D76602#1951483>, @nicolasvasilache wrote:
>
> > @bondhugula 
> >  Thanks for the refactoring!
> >
> > Dropping the LLVM flag and refactoring the impl further sounds like the right thing to do IMO.
> >  The unit test that uses the flag can easily be updated (or deprecated in favor of your test).
> >  The internal use case we have for this will be easy to update.
>
>
> This sounds the best to me too. I'll do it in this patch.


Done @nicolasvasilache  PTAL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76602/new/

https://reviews.llvm.org/D76602





More information about the llvm-commits mailing list