[PATCH] D76067: [llvm-dwp] Refactor handling of section identifiers. NFCI.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 5 17:06:21 PDT 2020


dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:262
     }
-    auto &C = Entry.Contributions[DW_SECT_TYPES - DW_SECT_INFO];
+    const unsigned TypesIndex = getContributionIndex(DW_SECT_TYPES);
+    auto &C = Entry.Contributions[TypesIndex];
----------------
LLVM doesn't generally use top level const on local variables - drop the "const" here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76067/new/

https://reviews.llvm.org/D76067





More information about the llvm-commits mailing list