[PATCH] D77467: [VPlan] Introduce new VPWidenCallRecipe (NFC).

[Ayal Zaks via Phabricator via llvm-commits]

Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4364
+  // Ignore dbg intrinsics.
+  if (isa<DbgInfoIntrinsic>(I))
+    return;
----------------
fhahn wrote:
> Ayal wrote:
> > Note that the *decision* not to widen calls to debug intrinsics should be made when building VPlan, in tryToWidenCall() or perhaps added to DeadInstructions(?), instead of here during code-gen.
> > Can be taken care of here, or in a subsequent patch along with migrating NeedToScalarize/UseVectorIntrinsics decisions "how" to widen calls.
> I noticed the same thing but I didn't want to turn this into an assertion in this patch, but rather as a follow-up. There might be something better we can do for debug info intrinsics (e.g. update the values they reference to the vector values), but as long as we just drop them, we should drop them early. I think best addressed in subsequent patches. WDYT?
Sure; perhaps worth leaving a TODO behind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77467/new/

https://reviews.llvm.org/D77467