[PATCH] D77449: [MLIR] Cleanup mlir-tblgen error messages for custom assembly formats.

Stephen Neuendorffer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 22:55:00 PDT 2020


stephenneuendorffer added a comment.

Is this along the lines of what you were thinking?   I'm not necessarily wild about having the location described twice (once in the error and once in the note).

Separately, I'm annoyed by the lack of line numbers.  I looked at this, but it seems like there is no good way to create a MemoryBuffer such that it has a Loc relative to an outer file.  The include mechanism does something similar, but is probably a little misleading.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77449/new/

https://reviews.llvm.org/D77449





More information about the llvm-commits mailing list