[PATCH] D77467: [VPlan] Introduce new VPWidenCallRecipe (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 4 14:22:25 PDT 2020
fhahn marked 6 inline comments as done.
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:717
+ VPSlotTracker &SlotTracker) const {
+ O << " +\n" << Indent << "\"WIDEN\\l\"";
+ O << "\" " << VPlanIngredient(&Ingredient) << "\\l\"";
----------------
gilr wrote:
> gilr wrote:
> > "WIDEN-CALL"
> Since it's a single-ingredient recipe, better make this a single-line print as in VPWidenPHIRecipe (actually also the case for VPWidenRecipe now).
Right, I wasn't entirely sure about the DOT syntax. I think the DOT syntax might be a bit verbose for just printing it in -debug. Maybe we should add a way to print a VPlan without DOT syntax (for regular debug output) and an option to toggle DOT/non-DOT output. WDYT?
> actually also the case for VPWidenRecipe now).
If the style here is fine I'll push a similar fix for VPWidenRecipe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77467/new/
https://reviews.llvm.org/D77467
More information about the llvm-commits
mailing list