[PATCH] D77467: [VPlan] Introduce new VPWidenCallRecipe (NFC).

[Gil Rapaport via Phabricator via llvm-commits]

gilr added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4233
   case Instruction::GetElementPtr:
     llvm_unreachable("This instruction is handled by a different recipe.");
   case Instruction::UDiv:
----------------
Instruction::Call now belongs here with the other special-widening instructions to explicitly denote it's being handled by another recipe.


================
Comment at: llvm/lib/Transforms/Vectorize/VPRecipeBuilder.h:110
 
+  VPWidenCallRecipe *tryToWidenCall(Instruction *I, VFRange &Range);
   /// Check if \p I can be widened within the given VF \p Range. If \p I can be
----------------
Missing a comment (and a newline).


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:717
+                              VPSlotTracker &SlotTracker) const {
+  O << " +\n" << Indent << "\"WIDEN\\l\"";
+  O << "\"  " << VPlanIngredient(&Ingredient) << "\\l\"";
----------------
"WIDEN-CALL"


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:717
+                              VPSlotTracker &SlotTracker) const {
+  O << " +\n" << Indent << "\"WIDEN\\l\"";
+  O << "\"  " << VPlanIngredient(&Ingredient) << "\\l\"";
----------------
gilr wrote:
> "WIDEN-CALL"
Since it's a single-ingredient recipe, better make this a single-line print as in VPWidenPHIRecipe (actually also the case for VPWidenRecipe now).


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:787
 
+class VPWidenCallRecipe : public VPRecipeBase {
+private:
----------------
Missing a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77467/new/

https://reviews.llvm.org/D77467