[PATCH] D77325: [InstCombine] Don't limit operands in eraseInstFromFunction()

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 10:04:46 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ede73009681: [InstCombine] Don't limit uses in eraseInstFromFunction() (authored by nikic).
Herald added a subscriber: hiraditya.

Changed prior to commit:
  https://reviews.llvm.org/D77325?vs=254578&id=255055#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77325/new/

https://reviews.llvm.org/D77325

Files:
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h


Index: llvm/lib/Transforms/InstCombine/InstCombineInternal.h
===================================================================
--- llvm/lib/Transforms/InstCombine/InstCombineInternal.h
+++ llvm/lib/Transforms/InstCombine/InstCombineInternal.h
@@ -724,11 +724,10 @@
 
     // Make sure that we reprocess all operands now that we reduced their
     // use counts.
-    if (I.getNumOperands() < 8) {
-      for (Use &Operand : I.operands())
-        if (auto *Inst = dyn_cast<Instruction>(Operand))
-          Worklist.add(Inst);
-    }
+    for (Use &Operand : I.operands())
+      if (auto *Inst = dyn_cast<Instruction>(Operand))
+        Worklist.add(Inst);
+
     Worklist.remove(&I);
     I.eraseFromParent();
     MadeIRChange = true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77325.255055.patch
Type: text/x-patch
Size: 740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200404/92abda03/attachment.bin>


More information about the llvm-commits mailing list