[PATCH] D76550: [Attributor] Improve the alignment of the loads

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 4 09:00:33 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM, with a small nit. Can you update the diff and provide me with "Firstname Lastname <email>" so I can upload this for you?



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5408
 
+    A.getAAFor<AAAlign>(*this, IRPosition::value(getAssociatedValue()));
+
----------------
Make it an optional dependence (see the extra arguments of `getAAFor`) so we don't give up once we give up on the alignment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76550/new/

https://reviews.llvm.org/D76550





More information about the llvm-commits mailing list