[PATCH] D77276: Clean up usages of asserting vector getters in Type

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/IR/Constants.cpp:1894
+    assert(CVTy->getElementCount() ==
+               cast<VectorType>(DstTy)->getElementCount() &&
            "Invalid cast between a different number of vector elements");
----------------
Please don't mix functional and non-functional changes.




================
Comment at: llvm/lib/IR/Constants.cpp:1908
+    assert(CVTy->getElementCount() ==
+               cast<VectorType>(DstTy)->getElementCount() &&
            "Invalid cast between a different number of vector elements");
----------------
Please don't mix functional and non-functional changes.


================
Comment at: llvm/lib/IR/Instructions.cpp:2953
+          cast<VectorType>(Ty)->getElementCount() ==
+              cast<VectorType>(S->getType())->getElementCount()) &&
          "Invalid cast");
----------------
Please don't mix functional and non-functional changes.




================
Comment at: llvm/lib/IR/Instructions.cpp:2972
+          cast<VectorType>(Ty)->getElementCount() ==
+              cast<VectorType>(S->getType())->getElementCount()) &&
          "Invalid cast");
----------------
Please don't mix functional and non-functional changes.




================
Comment at: llvm/lib/IR/Verifier.cpp:2830
+    Assert(SrcVTy->getElementCount() ==
+               cast<VectorType>(DestTy)->getElementCount(),
            "AddrSpaceCast vector pointer number of elements mismatch", &I);
----------------
Please don't mix functional and non-functional changes.




================
Comment at: llvm/lib/IR/Verifier.cpp:3348
+      if (auto *IndexVTy = dyn_cast<VectorType>(IndexTy)) {
+        ElementCount IndexWidth = IndexVTy->getElementCount();
         Assert(IndexWidth == GEPWidth, "Invalid GEP index vector width", &GEP);
----------------
Please don't mix functional and non-functional changes.




================
Comment at: llvm/lib/IR/Verifier.cpp:4663
+    Assert(cast<VectorType>(Mask->getType())->getElementCount() ==
+               cast<VectorType>(DataTy)->getElementCount(),
            "masked_load: vector mask must be same length as data", Call);
----------------
Please don't mix functional and non-functional changes.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77276/new/

https://reviews.llvm.org/D77276