[PATCH] D77426: [SampleFDO] Add flag for non-dedicated profile.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/IR/ProfileSummary.h:54
+  /// collected from the same target. Non-dedicated means the profile
+  /// being used for optimizing current target is generic and may not
+  /// be collected from the same target. Non-dedicated profile may only
----------------
--> If 'Dedicated' is false, it means the profile is for common/shared code. The common profile is merged from profiles collected from running other targets.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:174
+  SecFlagInValid = 0,
+  SecFlagNonDedicated = (1 << 0)
+};
----------------
SecFlagPartial or SecFlagShared?


================
Comment at: llvm/include/llvm/ProfileData/SampleProfWriter.h:223
+  // only partial coverage.
+  virtual void setNonDedicated() override {
+    addSectionFlag(SecProfSummary, SecProfSummaryFlags::SecFlagNonDedicated);
----------------
setPartialProfile or setSharedProfile?


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:850
+    if (hasSecFlag(Entry, SecProfSummaryFlags::SecFlagNonDedicated))
+      Flags.append("non-dedicated,");
+    break;
----------------
partial or shared?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77426/new/

https://reviews.llvm.org/D77426