[PATCH] D77417: [BFI][CGP] Add limited support for detecting missed BFI updates and fix one in CodeGenPrepare.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h:1467
+    }
+    for (auto &Entry : OtherValidNodes) {
+      const BlockT* OtherBB = Entry.first;
----------------
If there is no mismatch detected at this point, the following check is redundant.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:2220
+    BFI->setBlockFreq(BB,
+        (BFI->getBlockFreq(BB) - BFI->getBlockFreq(TailCallBB)).getFrequency());
     ModifiedDT = Changed = true;
----------------
Add assert that BB's frequency >= TailCallBB's freq?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77417/new/

https://reviews.llvm.org/D77417