[PATCH] D77423: [WebAssembly] Fix wasm.lsda() optimization in WasmEHPrepare

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

LGTM. I think IsFoo is probably fine even for plurals because it's a common convention as you say.
I guess if you wanted to be ultra-nitpicky-correct you could capitalize it as `IsEHPadFunctionsSetUp` (i.e. "set up" as 2 words instead of 1 since "setup" is a noun and "set up" is a verb phrase). But it's probably not worth bothering to change.



================
Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:127
 
+  // This set includes EH pad instructions for EH pads that have wasm.lsda()
+  // call either in the current EH pad or any of its parent EH pads that
----------------
Did you want to move this comment too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77423/new/

https://reviews.llvm.org/D77423