[PATCH] D76954: LLVM support for BB-cluster sections

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 14:39:03 PDT 2020


rahmanl marked 5 inline comments as done.
rahmanl added a comment.

Handled all of @tmsriram 's 3rd round of comments.



================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:552
 // Returns true if this basic block and the Other are in the same section.
 bool MachineBasicBlock::sameSection(const MachineBasicBlock *Other) const {
+  return this->getSectionID() == Other->getSectionID();
----------------
tmsriram wrote:
> This has become too simple, maybe just delete the function or move the body to the header file itself?
Moved the definition to the header file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76954/new/

https://reviews.llvm.org/D76954





More information about the llvm-commits mailing list